pissang edited a comment on pull request #13314: URL: https://github.com/apache/incubator-echarts/pull/13314#issuecomment-695879944
https://echarts-bench-from-uplot.glitch.me/uplot-smoothing.html I tried it and seems a bit different from my Catmull-Rom spline implementation. Haven't dig into it and not sure if it's because I draw the spline with interpolated points and in the uplot are bezier curves. But it looks similar to our original bezier curve implementation without limiting to min, max extremes. The problem is the curve will exceed the extremes. For example under the 0 baseline or exceed the max value(if the max value has some meaning like 100 percent.  If we limiting the curve between global min, max extremes. https://echarts-bench-from-uplot.glitch.me/uplot-smoothing-limit-extrema.html It becomes almost the same as the result before change in this PR.  ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
