pissang commented on a change in pull request #13398:
URL:
https://github.com/apache/incubator-echarts/pull/13398#discussion_r502740784
##########
File path: src/component/tooltip/TooltipHTMLContent.ts
##########
@@ -386,8 +392,9 @@ class TooltipHTMLContent {
}
hide() {
- this.el.style.display = 'none';
+ this.el.style.opacity = '0';
this._show = false;
+ this._longHideTimeout = setTimeout(() => this._longHide = true, 500)
as any;
}
Review comment:
I think we still need to set `display: 'none'` when `this._longHide =
true`. I'm not sure if it will cause other issues like cover the graph and
cause interaction issues. if only set the opacity to `0`.
Also, should the time `500ms` plus user set hideDelay?
##########
File path: src/component/tooltip/TooltipHTMLContent.ts
##########
@@ -386,8 +392,9 @@ class TooltipHTMLContent {
}
hide() {
- this.el.style.display = 'none';
+ this.el.style.opacity = '0';
this._show = false;
+ this._longHideTimeout = setTimeout(() => this._longHide = true, 500)
as any;
}
Review comment:
I think we still need to set `display: 'none'` when `this._longHide =
true`. I'm not sure if it will cause other issues like cover the graph and
cause interaction issues. if only set the opacity to `0`.
Also, should the time `500ms` plus user set `hideDelay`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
