plainheart edited a comment on pull request #13732: URL: https://github.com/apache/incubator-echarts/pull/13732#issuecomment-744205711
> I'm not sure if we should remove the edge condition here. edge is using chromium now @pissang I think we may need to tweak the logic of checking if the browser is Edge in zrender. Before using chromium core, the latest version of Edge is `18.x`. Now it's increasing from `78.x`. **Changes in zrender would be:** ```diff // https://github.com/ecomfe/zrender/blob/master/src/core/env.ts#L58 - const edge = ua.match(/Edge\/([\d.]+)/); + const edge = ua.match(/Edge?\/([\d.]+)/); // make `e` optional to match new edge with chromium core. ``` Old UserAgent ``` Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.102 Safari/537.36 Edge/18.18363 ``` New UserAgent ``` Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.88 Safari/537.36 Edg/87.0.664.60 ``` Related commit in zrender is https://github.com/ecomfe/zrender/pull/673/commits/d53d616f3e42c86c0465a2343210ab98f35b8f3a **So, the judgment here should be:** ```js // Chrome, Firefox, New Edge if (typeof MouseEvent === 'function' && (env.browser.newEdge || (!env.browser.ie && !env.browser.edge))) { ``` The related commit is https://github.com/apache/incubator-echarts/pull/13732/commits/177f1fc5dd489e90eb1c4cf055e342fbc4f6ef32 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
