Ovilia opened a new pull request #14314:
URL: https://github.com/apache/echarts/pull/14314


   <!-- Please fill in the following information to help us review your PR more 
efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   <!-- USE ONCE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
   
   `string` is a valid type for `markLine.data` because time axis values can be 
string. This PR adds `string` to its type.
   
   ### Fixed issues
   
   - #14300: MarkLine1DDataItemOption incorrectly defines xAxis as number
   
   ## Details
   
   ### Before: What was the problem?
   
   Only `number` is supported for MarkLine1DDataItemOption.xAxis.
   
   
   ### After: How is it fixed in this PR?
   
   Set the type to be `number | string`.
   
   
   
   ## Usage
   
   ### Are there any API changes?
   
   - [ ] The API has been changed.
   
   <!-- LIST THE API CHANGES HERE -->
   
   
   
   ### Related test cases or examples to use the new APIs
   
   NA.
   
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merge.
   
   ### Other information
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to