susiwen8 commented on a change in pull request #14343:
URL: https://github.com/apache/echarts/pull/14343#discussion_r582509664
##########
File path: src/component/marker/MarkAreaView.ts
##########
@@ -248,22 +248,19 @@ class MarkAreaView extends MarkerView {
const points = map(dimPermutations, function (dim) {
return getSingleMarkerEndPoint(areaData, idx, dim,
seriesModel, api);
});
+ const xAxis = coordSys.getAxis('x').scale.getExtent();
+ const yAxis = coordSys.getAxis('y').scale.getExtent();
+ const xPoint =
[coordSys.getAxis('x').scale.parse(areaData.get('x0', idx)),
Review comment:
It's better to 'cache' `coordSys.getAxis('x').scale` and
`coordSys.getAxis('y').scale`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
