Rain120 commented on a change in pull request #16493:
URL: https://github.com/apache/echarts/pull/16493#discussion_r805564189
##########
File path: src/chart/heatmap/HeatmapView.ts
##########
@@ -245,13 +259,19 @@ class HeatmapView extends ChartView {
dataDimY
]);
+ const shape: Shape = {
+ x: Math.floor(Math.round(point[0]) - width / 2),
+ y: Math.floor(Math.round(point[1]) - height / 2),
+ width: Math.ceil(width),
+ height: Math.ceil(height)
+ };
+
+ if (borderRadius || Array.isArray(borderRadius)) {
Review comment:
It means, we just need to get the value and assign it, the value about
type check uses the TypeScript compiler, bcs we just care about the value.
wonderful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
