plainheart commented on a change in pull request #16493:
URL: https://github.com/apache/echarts/pull/16493#discussion_r806421923
##########
File path: src/chart/heatmap/HeatmapView.ts
##########
@@ -22,7 +22,7 @@ import { toggleHoverEmphasis } from '../../util/states';
import HeatmapLayer from './HeatmapLayer';
import * as zrUtil from 'zrender/src/core/util';
import ChartView from '../../view/Chart';
-import HeatmapSeriesModel, { HeatmapDataItemOption } from './HeatmapSeries';
+import HeatmapSeriesModel, { BorderRadius, HeatmapDataItemOption } from
'./HeatmapSeries';
Review comment:
The imported type `BorderRadius` is unused and can be removed here.
##########
File path: src/chart/heatmap/HeatmapView.ts
##########
@@ -31,7 +31,7 @@ import type ContinuousModel from
'../../component/visualMap/ContinuousModel';
import { CoordinateSystem, isCoordinateSystemType } from
'../../coord/CoordinateSystem';
import { StageHandlerProgressParams, Dictionary, OptionDataValue } from
'../../util/types';
import type Cartesian2D from '../../coord/cartesian/Cartesian2D';
-import type Calendar from '../../coord/calendar/Calendar';
+import Calendar from '../../coord/calendar/Calendar';
Review comment:
May I know why you removed the `type` keyword here?
##########
File path: src/chart/heatmap/HeatmapSeries.ts
##########
@@ -41,14 +41,18 @@ import type Calendar from '../../coord/calendar/Calendar';
type HeatmapDataValue = OptionDataValue[];
+export type BorderRadius = number | number[];
Review comment:
This definition for the `BorderRadius` type is unnecessary and can be
merged into line 49 below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
