susiwen8 commented on a change in pull request #16619:
URL: https://github.com/apache/echarts/pull/16619#discussion_r821783026
##########
File path: test/lib/simpleRequire.js
##########
@@ -142,7 +142,7 @@
var factoryRet = factory.apply(null, deps.map(function (dep) {
return dep === exportsPlaceholder ? modExports : dep;
}));
- return factoryRet || modExports;
+ return factoryRet || modExports.exports || modExports;
Review comment:
Well, `modExports` would be an argument for `factory` function, as
matter of fact, variable `modExports` will be variable `module` when function
runs. Then as I have mention above, The `exports` attribute of `module` will
have whatever `echarts` have exported.
```js
modExports = {
exports: echarts.
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
