pissang commented on a change in pull request #16691:
URL: https://github.com/apache/echarts/pull/16691#discussion_r829630324
##########
File path: src/component/toolbox/feature/DataView.ts
##########
@@ -363,7 +364,7 @@ class DataView extends
ToolboxFeature<ToolboxDataViewFeatureOption> {
textarea.readOnly = model.get('readOnly');
const style = textarea.style;
// eslint-disable-next-line max-len
- style.cssText =
'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none';
+ style.cssText =
'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none;vertical-align:middle;box-sizing:border-box;outline:none';
Review comment:
I'm not sure if this `vertical-align:middle;` is necessary.
##########
File path: src/component/toolbox/feature/DataView.ts
##########
@@ -363,7 +364,7 @@ class DataView extends
ToolboxFeature<ToolboxDataViewFeatureOption> {
textarea.readOnly = model.get('readOnly');
const style = textarea.style;
// eslint-disable-next-line max-len
- style.cssText =
'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none';
+ style.cssText =
'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none;vertical-align:middle;box-sizing:border-box;outline:none';
Review comment:
Didn't aware the default display of textarea is `inline-block`. Perhaps
setting `display` to `block` will be better?
##########
File path: src/component/toolbox/feature/DataView.ts
##########
@@ -363,7 +364,7 @@ class DataView extends
ToolboxFeature<ToolboxDataViewFeatureOption> {
textarea.readOnly = model.get('readOnly');
const style = textarea.style;
// eslint-disable-next-line max-len
- style.cssText =
'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none';
+ style.cssText =
'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none;vertical-align:middle;box-sizing:border-box;outline:none';
Review comment:
Thanks for the explaination. Didn't aware the default display of
textarea is `inline-block`. Perhaps setting `display` to `block` will be better?
##########
File path: src/component/toolbox/feature/DataView.ts
##########
@@ -363,7 +364,7 @@ class DataView extends
ToolboxFeature<ToolboxDataViewFeatureOption> {
textarea.readOnly = model.get('readOnly');
const style = textarea.style;
// eslint-disable-next-line max-len
- style.cssText =
'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none';
+ style.cssText =
'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none;vertical-align:middle;box-sizing:border-box;outline:none';
Review comment:
Thanks for the explaination. Didn't aware the default display of
textarea is `inline-block`. Perhaps setting `display` to `block` will be
better? I'm not sure
##########
File path: src/component/toolbox/feature/DataView.ts
##########
@@ -363,7 +364,7 @@ class DataView extends
ToolboxFeature<ToolboxDataViewFeatureOption> {
textarea.readOnly = model.get('readOnly');
const style = textarea.style;
// eslint-disable-next-line max-len
- style.cssText =
'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none';
+ style.cssText =
'width:100%;height:100%;font-family:monospace;font-size:14px;line-height:1.6rem;resize:none;vertical-align:middle;box-sizing:border-box;outline:none';
Review comment:
Thanks for the explanation. Didn't aware the default display of textarea
is `inline-block`. Perhaps setting `display` to `block` will be better? I'm not
sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
