pissang commented on pull request #16542: URL: https://github.com/apache/echarts/pull/16542#issuecomment-1077022678
Sorry for the late review. The `ignore` property of `label` and `labelLine` is updated in https://github.com/apache/echarts/blob/ad3a07a4bc699f540d2c977160cfc466fa77793b/src/label/labelStyle.ts#L250 https://github.com/apache/echarts/blob/ad3a07a4bc699f540d2c977160cfc466fa77793b/src/label/labelGuideHelper.ts#L623 Especially the `labelLine`, it has complex logic to determine if it can be shown when label is not shown. But for some reason it fails when switching from show to hide in the emphasis state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
