plainheart commented on pull request #16736: URL: https://github.com/apache/echarts/pull/16736#issuecomment-1077289435
@jiawulin001 So much thanks for your deep dig. I've mentioned a bit in the MR description what you are concerned about [1]. That's why I didn't apply the changes to other places. [1] > It will throw illegal argument errors as zrender basic shape `Circle` doesn't handle the value less than 0, unlike the `Sector` shape, it normalizes such an unexpected radius value. - https://github.com/ecomfe/zrender/blob/master/src/graphic/helper/roundSector.ts#L126-L127 - https://github.com/ecomfe/zrender/blob/master/src/graphic/shape/Circle.ts#L32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
