This is an automated email from the ASF dual-hosted git repository.
ovilia pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/echarts.git
The following commit(s) were added to refs/heads/master by this push:
new 734cfbf46 chore: remove some unintentional comment
new e2d26a298 Merge pull request #17172 from susiwen8/fix-comment
734cfbf46 is described below
commit 734cfbf4640f107ee79826cdafe95842ae40ec4d
Author: susiwen8 <susiw...@gmail.com>
AuthorDate: Tue Jun 7 15:36:58 2022 +0800
chore: remove some unintentional comment
---
src/chart/treemap/TreemapSeries.ts | 6 ------
src/model/Global.ts | 2 +-
src/model/Model.ts | 6 +++---
src/util/clazz.ts | 4 ++--
src/util/types.ts | 6 +++---
5 files changed, 9 insertions(+), 15 deletions(-)
diff --git a/src/chart/treemap/TreemapSeries.ts
b/src/chart/treemap/TreemapSeries.ts
index 241837c9f..50228e4ed 100644
--- a/src/chart/treemap/TreemapSeries.ts
+++ b/src/chart/treemap/TreemapSeries.ts
@@ -336,12 +336,6 @@ class TreemapSeriesModel extends
SeriesModel<TreemapSeriesOption> {
levels: [] // Each item: {
// visibleMin, itemStyle,
visualDimension, label
// }
- // data: {
- // value: [],
- // children: [],
- // link: 'http://xxx.xxx.xxx',
- // target: 'blank' or 'self'
- // }
};
/**
diff --git a/src/model/Global.ts b/src/model/Global.ts
index b4268b38a..d4777a4ee 100644
--- a/src/model/Global.ts
+++ b/src/model/Global.ts
@@ -682,7 +682,7 @@ echarts.use([${seriesImportName}]);`);
* });
* eachComponent(function (componentType, model, index) {
* // componentType does not include subType
- * // (componentType is 'xxx' but not 'xxx.aa')
+ * // (componentType is 'a' but not 'a.b')
* });
* eachComponent(
* {mainType: 'dataZoom', query: {dataZoomId: 'abc'}},
diff --git a/src/model/Model.ts b/src/model/Model.ts
index 3ebffaf4e..54babe69f 100644
--- a/src/model/Model.ts
+++ b/src/model/Model.ts
@@ -103,7 +103,7 @@ class Model<Opt = ModelOption> { // TODO: TYPE use
unknown instead of any?
get<R extends keyof Opt, S extends keyof Opt[R], T extends keyof
Opt[R][S]>(
path: readonly [R, S, T], ignoreParent?: boolean
): Opt[R][S][T];
- // `path` can be 'xxx.yyy.zzz', so the return value type have to be
`ModelOption`
+ // `path` can be 'a.b.c', so the return value type have to be `ModelOption`
// TODO: TYPE strict key check?
// get(path: string | string[], ignoreParent?: boolean): ModelOption;
get(path: string | readonly string[], ignoreParent?: boolean): ModelOption
{
@@ -149,9 +149,9 @@ class Model<Opt = ModelOption> { // TODO: TYPE use
unknown instead of any?
getModel<R extends keyof Opt, S extends keyof Opt[R], T extends keyof
Opt[R][S]>(
path: readonly [R, S, T], parentModel?: Model
): Model<Opt[R][S][T]>;
- // `path` can be 'xxx.yyy.zzz', so the return value type have to be
`Model<ModelOption>`
+ // `path` can be 'a.b.c', so the return value type have to be
`Model<ModelOption>`
// getModel(path: string | string[], parentModel?: Model): Model;
- // TODO 'xxx.yyy.zzz' is deprecated
+ // TODO 'a.b.c' is deprecated
getModel(path: string | readonly string[], parentModel?: Model):
Model<any> {
const hasPath = path != null;
const pathFinal = hasPath ? this.parsePath(path) : null;
diff --git a/src/util/clazz.ts b/src/util/clazz.ts
index c3df60b31..b340fdb62 100644
--- a/src/util/clazz.ts
+++ b/src/util/clazz.ts
@@ -231,8 +231,8 @@ export function enableClassManagement(
* Component model classes
* key: componentType,
* value:
- * componentClass, when componentType is 'xxx'
- * or Object.<subKey, componentClass>, when componentType is 'xxx.yy'
+ * componentClass, when componentType is 'a'
+ * or Object.<subKey, componentClass>, when componentType is 'a.b'
*/
const storage: {
[componentMainType: string]: (Constructor | SubclassContainer)
diff --git a/src/util/types.ts b/src/util/types.ts
index e8d3f1d18..3e9eb31cf 100644
--- a/src/util/types.ts
+++ b/src/util/types.ts
@@ -87,8 +87,8 @@ export type ZRStyleProps = PathStyleProps | ImageStyleProps |
TSpanStyleProps |
export type ZRElementEventName = ElementEventName | 'globalout';
// ComponentFullType can be:
-// 'xxx.yyy': means ComponentMainType.ComponentSubType.
-// 'xxx': means ComponentMainType.
+// 'a.b': means ComponentMainType.ComponentSubType.
+// 'a': means ComponentMainType.
// See `checkClassType` check the restict definition.
export type ComponentFullType = string;
export type ComponentMainType = keyof ECUnitOption & string;
@@ -96,7 +96,7 @@ export type ComponentSubType =
Exclude<ComponentOption['type'], undefined>;
/**
* Use `parseClassType` to parse componentType declaration to
componentTypeInfo.
* For example:
- * componentType declaration: 'xxx.yyy', get componentTypeInfo {main: 'xxx',
sub: 'yyy'}.
+ * componentType declaration: 'a.b', get componentTypeInfo {main: 'a', sub:
'b'}.
* componentType declaration: '', get componentTypeInfo {main: '', sub: ''}.
*/
export interface ComponentTypeInfo {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
