MicroLightAzaf commented on PR #17212: URL: https://github.com/apache/echarts/pull/17212#issuecomment-1162085445
> Please add different values of `nameTextStyle.align` in the test cases. I think the logic is still not correct. For example, when `align: left`, it is like this now, which I think the constraining width is too small. > > <img alt="image" width="541" src="https://github.com/assets/779050/7333c817-2154-4350-9891-7b8689ef0743";> > > BTW, I think you don't have to use so many data in the test cases since they are designed to test the axis names rather than the scatter series. Minify the data can make the test code to be cleaner and easier to debug. You can use the data like [this one](https://echarts.apache.org/examples/zh/editor.html?c=line-simple). Thanks for the guidance! I minified the data for the test case and added different test parameters for `nameTextStyle.align`. In the example you mentioned, what is truncated is probably the `yAxis` axis name, so the length of the `yAxis` is used for truncation. Maybe you meant that it would be better to follow the direction of the text to determine the default truncation length? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
