pissang commented on PR #17349: URL: https://github.com/apache/echarts/pull/17349#issuecomment-1180598511
I'm not pretty sure but I think it's by design at original. Like the logic of option merging, giving `null` means not updating this element in the default merge mode. If we wan't to remove it, we need to change the `$mergeChildren` to false, which will loose the transition. Perhaps @100pah can give more explanation on this. But from my side. I think the change in this PR will let code much more intuitionistic. So I will give +1 on this change(and a bit more explanation on the doc will be better). The only change I need to request is that we still need to `applyLeaveTransition` when removing the child instead of using `remove` directly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
