pissang commented on PR #17426: URL: https://github.com/apache/echarts/pull/17426#issuecomment-1203554849
> I'm not quite sure about if it's proper to make a done callback for group animations It looks good to me. This method is used on the axis component only so I think this change has very little chance of breaking other components. > Should I check axisModel to get if there is animation and call setGroupSubPixelOptimize if not This is not necessary. `groupTransition` will still call the done callback when animation is set to false. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
