Ovilia commented on PR #17426: URL: https://github.com/apache/echarts/pull/17426#issuecomment-1207901160
@pissang I added [the logic](https://github.com/apache/echarts/pull/17426/files#diff-36702e9ce5f4d6cb00be763ce719953d6fd5384008ad5959e96502145ae344a5L396-R408) so that `done` callback is called if old or new group doesn't exist in `groupTransition`. Should I also traverse and check if `g1` and `g2` are the same? If so, `done` should be called and `return` before further logic. One concern is, with zrender animation, if an element is set with the same attribute, the `done` is still called after the duration, rather than instantly. So I guess it's not a good idea to call `done` instantly in `groupTransition`. Other way to fix this is before calling [graphic.groupTransition](https://github.com/apache/echarts/pull/17426/files#diff-3457dced5b6a1daeb0cce9c076a1cf1c31a9cafde7cee7feb35e265e93ae7669R105), I first traverse the group to check if anything changes and call `graphic.setGroupSubPixelOptimize(this._axisGroup, true)` and skip `graphic.groupTransition` if the group doesn't change, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
