[GitHub] [echarts] plainheart opened a new pull request, #17920: fix(pie): fix `center` may not be converted to correct point when coordinate system is specified

Tue, 15 Nov 2022 03:18:34 -0800 


plainheart opened a new pull request, #17920:
URL: https://github.com/apache/echarts/pull/17920

   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   
   
   ### What does this PR do?
   
   Fix a bug that exists in #17132 (v5.4.0)
   
   Due to being normalized to an array, the `center` may not be converted to 
the correct point when the coordinate system is specified. For example, just 
like the LngLat array, `center: 'Beijing'` should also be converted to the 
correct pixel when using the `geo` coordinate system.
   
   ### Fixed issues
   
   - #17132
   
   ## Details
   
   ### Before: What was the problem?
   
   <img 
src="https://user-images.githubusercontent.com/26999792/201906230-e7ee9232-1bde-43d3-bf87-8b0339ef5931.png";
 width="600">
   
   ### After: How does it behave after the fixing?
   
   <img 
src="https://user-images.githubusercontent.com/26999792/201906034-585483a4-80a6-403c-bdef-c77fbadcc029.png";
 width="600">
   
   ## Document Info
   
   One of the following should be checked.
   
   - [x] This PR doesn't relate to document changes
   - [ ] The document should be updated later
   - [ ] The document changes have been made in apache/echarts-doc#xxx
   
   
   
   ## Misc
   
   ### ZRender Changes
   
   - [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
   
   ### Related test cases or examples to use the new APIs
   
   Please refer to the 2nd and 7th `test/pie-coordinate-system.html`
   
   
   ## Others
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merging.
   
   ### Other information
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to