plainheart commented on code in PR #318:
URL: https://github.com/apache/echarts-doc/pull/318#discussion_r1036120787


##########
en/changelog.md:
##########
@@ -1,3 +1,30 @@
+## v5.4.1
+
++ [Feature] [i18n]: add Hungarian(hu_HU) translation 
[#17978](https://github.com/apache/echarts/issues/17978) 
([ifjkovacsik](https://github.com/ifjkovacsik))
++ [Feature] [type]: export `ECElementEvent` for TypeScript 
[#17892](https://github.com/apache/echarts/issues/17892) 
([keita-determined](https://github.com/keita-determined))
++ [Feature] [svg]: support gradients and patterns for background color in SVG 
renderer [#959](https://github.com/ecomfe/zrender/issues/959) 
([plainheart](https://github.com/plainheart))
++ [Feature] [candlestick]: provide borderColorDoji option for custom doji 
color [#17717](https://github.com/apache/echarts/issues/17717) 
([Ovilia](https://github.com/Ovilia))
++ [Feature] [sankey]: `sankey` support `edgeLabel` 
[#16767](https://github.com/apache/echarts/issues/16767) 
([susiwen8](https://github.com/susiwen8))
++ [Feature] [graph]: make graph node draggable in `none` and `circular` layout 
[#15428](https://github.com/apache/echarts/issues/15428) 
([kongmoumou](https://github.com/kongmoumou))
++ [Fix] [dataZoom]: fallback to extent start/end when value or percent is 
invalid [#17934](https://github.com/apache/echarts/issues/17934) 
([plainheart](https://github.com/plainheart))
++ [Fix] [pie]: fix `center` may not be converted to correct point when 
coordinate system is specified 
[#17920](https://github.com/apache/echarts/issues/17920) 
([plainheart](https://github.com/plainheart))
++ [Fix] [type]: add `string` & `number` type into the `center` option of pie 
series [#17917](https://github.com/apache/echarts/issues/17917) 
([plainheart](https://github.com/plainheart))
++ [Fix] [heatmap]: fix heatmap label may overlap when `dataZoom` is enabled 
[#17876](https://github.com/apache/echarts/issues/17876) 
([plainheart](https://github.com/plainheart))
++ [Fix] [tooltip]: fix tooltip arrow may cover the content when border is wide 
[#17875](https://github.com/apache/echarts/issues/17875) 
([plainheart](https://github.com/plainheart))
++ [Fix] [i18n]: language code for Ukrainian is UK, not UA (follow-up) 
[#17812](https://github.com/apache/echarts/issues/17812) 
([striezel](https://github.com/striezel))
++ [Fix] [type]: add overflow property to AxisLabelBaseOption interface. close 
#17363 [#17808](https://github.com/apache/echarts/issues/17808) 
([breizh24](https://github.com/breizh24))
++ [Fix] [lines)]: add missing `function` callback into `lineStyle.color` for 
lines series. [#17780](https://github.com/apache/echarts/issues/17780) 
([plainheart](https://github.com/plainheart))

Review Comment:
   The scope of this change should be `type` rather than `lines` and please put 
this item below.



##########
en/changelog.md:
##########
@@ -1,3 +1,30 @@
+## v5.4.1
+
++ [Feature] [i18n]: add Hungarian(hu_HU) translation 
[#17978](https://github.com/apache/echarts/issues/17978) 
([ifjkovacsik](https://github.com/ifjkovacsik))
++ [Feature] [type]: export `ECElementEvent` for TypeScript 
[#17892](https://github.com/apache/echarts/issues/17892) 
([keita-determined](https://github.com/keita-determined))
++ [Feature] [svg]: support gradients and patterns for background color in SVG 
renderer [#959](https://github.com/ecomfe/zrender/issues/959) 
([plainheart](https://github.com/plainheart))
++ [Feature] [candlestick]: provide borderColorDoji option for custom doji 
color [#17717](https://github.com/apache/echarts/issues/17717) 
([Ovilia](https://github.com/Ovilia))
++ [Feature] [sankey]: `sankey` support `edgeLabel` 
[#16767](https://github.com/apache/echarts/issues/16767) 
([susiwen8](https://github.com/susiwen8))
++ [Feature] [graph]: make graph node draggable in `none` and `circular` layout 
[#15428](https://github.com/apache/echarts/issues/15428) 
([kongmoumou](https://github.com/kongmoumou))
++ [Fix] [dataZoom]: fallback to extent start/end when value or percent is 
invalid [#17934](https://github.com/apache/echarts/issues/17934) 
([plainheart](https://github.com/plainheart))
++ [Fix] [pie]: fix `center` may not be converted to correct point when 
coordinate system is specified 
[#17920](https://github.com/apache/echarts/issues/17920) 
([plainheart](https://github.com/plainheart))
++ [Fix] [type]: add `string` & `number` type into the `center` option of pie 
series [#17917](https://github.com/apache/echarts/issues/17917) 
([plainheart](https://github.com/plainheart))
++ [Fix] [heatmap]: fix heatmap label may overlap when `dataZoom` is enabled 
[#17876](https://github.com/apache/echarts/issues/17876) 
([plainheart](https://github.com/plainheart))
++ [Fix] [tooltip]: fix tooltip arrow may cover the content when border is wide 
[#17875](https://github.com/apache/echarts/issues/17875) 
([plainheart](https://github.com/plainheart))
++ [Fix] [i18n]: language code for Ukrainian is UK, not UA (follow-up) 
[#17812](https://github.com/apache/echarts/issues/17812) 
([striezel](https://github.com/striezel))

Review Comment:
   The message of this item needs to be updated. 
https://github.com/apache/echarts/pull/17812



##########
en/changelog.md:
##########
@@ -1,3 +1,30 @@
+## v5.4.1
+
++ [Feature] [i18n]: add Hungarian(hu_HU) translation 
[#17978](https://github.com/apache/echarts/issues/17978) 
([ifjkovacsik](https://github.com/ifjkovacsik))
++ [Feature] [type]: export `ECElementEvent` for TypeScript 
[#17892](https://github.com/apache/echarts/issues/17892) 
([keita-determined](https://github.com/keita-determined))
++ [Feature] [svg]: support gradients and patterns for background color in SVG 
renderer [#959](https://github.com/ecomfe/zrender/issues/959) 
([plainheart](https://github.com/plainheart))
++ [Feature] [candlestick]: provide borderColorDoji option for custom doji 
color [#17717](https://github.com/apache/echarts/issues/17717) 
([Ovilia](https://github.com/Ovilia))
++ [Feature] [sankey]: `sankey` support `edgeLabel` 
[#16767](https://github.com/apache/echarts/issues/16767) 
([susiwen8](https://github.com/susiwen8))
++ [Feature] [graph]: make graph node draggable in `none` and `circular` layout 
[#15428](https://github.com/apache/echarts/issues/15428) 
([kongmoumou](https://github.com/kongmoumou))
++ [Fix] [dataZoom]: fallback to extent start/end when value or percent is 
invalid [#17934](https://github.com/apache/echarts/issues/17934) 
([plainheart](https://github.com/plainheart))
++ [Fix] [pie]: fix `center` may not be converted to correct point when 
coordinate system is specified 
[#17920](https://github.com/apache/echarts/issues/17920) 
([plainheart](https://github.com/plainheart))
++ [Fix] [type]: add `string` & `number` type into the `center` option of pie 
series [#17917](https://github.com/apache/echarts/issues/17917) 
([plainheart](https://github.com/plainheart))
++ [Fix] [heatmap]: fix heatmap label may overlap when `dataZoom` is enabled 
[#17876](https://github.com/apache/echarts/issues/17876) 
([plainheart](https://github.com/plainheart))
++ [Fix] [tooltip]: fix tooltip arrow may cover the content when border is wide 
[#17875](https://github.com/apache/echarts/issues/17875) 
([plainheart](https://github.com/plainheart))
++ [Fix] [i18n]: language code for Ukrainian is UK, not UA (follow-up) 
[#17812](https://github.com/apache/echarts/issues/17812) 
([striezel](https://github.com/striezel))
++ [Fix] [type]: add overflow property to AxisLabelBaseOption interface. close 
#17363 [#17808](https://github.com/apache/echarts/issues/17808) 
([breizh24](https://github.com/breizh24))

Review Comment:
   It's good to wrap the keyword `overflow` & `AxisLabelBaseOption` with \`



##########
en/changelog.md:
##########
@@ -1,3 +1,30 @@
+## v5.4.1
+
++ [Feature] [i18n]: add Hungarian(hu_HU) translation 
[#17978](https://github.com/apache/echarts/issues/17978) 
([ifjkovacsik](https://github.com/ifjkovacsik))
++ [Feature] [type]: export `ECElementEvent` for TypeScript 
[#17892](https://github.com/apache/echarts/issues/17892) 
([keita-determined](https://github.com/keita-determined))
++ [Feature] [svg]: support gradients and patterns for background color in SVG 
renderer [#959](https://github.com/ecomfe/zrender/issues/959) 
([plainheart](https://github.com/plainheart))
++ [Feature] [candlestick]: provide borderColorDoji option for custom doji 
color [#17717](https://github.com/apache/echarts/issues/17717) 
([Ovilia](https://github.com/Ovilia))
++ [Feature] [sankey]: `sankey` support `edgeLabel` 
[#16767](https://github.com/apache/echarts/issues/16767) 
([susiwen8](https://github.com/susiwen8))
++ [Feature] [graph]: make graph node draggable in `none` and `circular` layout 
[#15428](https://github.com/apache/echarts/issues/15428) 
([kongmoumou](https://github.com/kongmoumou))
++ [Fix] [dataZoom]: fallback to extent start/end when value or percent is 
invalid [#17934](https://github.com/apache/echarts/issues/17934) 
([plainheart](https://github.com/plainheart))
++ [Fix] [pie]: fix `center` may not be converted to correct point when 
coordinate system is specified 
[#17920](https://github.com/apache/echarts/issues/17920) 
([plainheart](https://github.com/plainheart))
++ [Fix] [type]: add `string` & `number` type into the `center` option of pie 
series [#17917](https://github.com/apache/echarts/issues/17917) 
([plainheart](https://github.com/plainheart))
++ [Fix] [heatmap]: fix heatmap label may overlap when `dataZoom` is enabled 
[#17876](https://github.com/apache/echarts/issues/17876) 
([plainheart](https://github.com/plainheart))
++ [Fix] [tooltip]: fix tooltip arrow may cover the content when border is wide 
[#17875](https://github.com/apache/echarts/issues/17875) 
([plainheart](https://github.com/plainheart))
++ [Fix] [i18n]: language code for Ukrainian is UK, not UA (follow-up) 
[#17812](https://github.com/apache/echarts/issues/17812) 
([striezel](https://github.com/striezel))
++ [Fix] [type]: add overflow property to AxisLabelBaseOption interface. close 
#17363 [#17808](https://github.com/apache/echarts/issues/17808) 
([breizh24](https://github.com/breizh24))
++ [Fix] [lines)]: add missing `function` callback into `lineStyle.color` for 
lines series. [#17780](https://github.com/apache/echarts/issues/17780) 
([plainheart](https://github.com/plainheart))
++ [Fix] [pie]: fix percent isn't updated after the legend is changed 
[#17734](https://github.com/apache/echarts/issues/17734) 
([plainheart](https://github.com/plainheart))
++ [Fix] [type]: EChartsInitOpts type error about height and width. close 
#17667 [#17727](https://github.com/apache/echarts/issues/17727) 
([MainHou](https://github.com/MainHou))
++ [Fix] [pie]: fix `labelLine` NPE when `minShowLabelRadian` is set 
[#17715](https://github.com/apache/echarts/issues/17715) 
([plainheart](https://github.com/plainheart))
++ [Fix] [gauge]: add gauge sectors in the order of the "clockwise" option 
[#17691](https://github.com/apache/echarts/issues/17691) 
([ZeekoZhu](https://github.com/ZeekoZhu))
++ [Fix] [timeline]: fix chart can't work when axis line is not shown 
[#17647](https://github.com/apache/echarts/issues/17647) 
([plainheart](https://github.com/plainheart))
++ [Fix] [universalTransition]: incorrect dataGroupId for old data items in 
universalTransition [#17559](https://github.com/apache/echarts/issues/17559) 
([tyn1998](https://github.com/tyn1998))

Review Comment:
   It's better to set the scope to `animation`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to