This is an automated email from the ASF dual-hosted git repository.
ovilia pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/echarts.git
The following commit(s) were added to refs/heads/master by this push:
new a29290ad7 chore: fix several typos
new b76eff2b3 Merge pull request #18061 from striezel-stash/several-typos
a29290ad7 is described below
commit a29290ad7748d9e3e864445ab81629c3279187b5
Author: Dirk Stolle <[email protected]>
AuthorDate: Wed Dec 14 01:21:49 2022 +0100
chore: fix several typos
---
src/component/axisPointer/BaseAxisPointer.ts | 8 ++++----
src/component/axisPointer/axisTrigger.ts | 6 +++---
src/component/axisPointer/modelHelper.ts | 8 ++++----
src/component/axisPointer/viewHelper.ts | 2 +-
src/component/dataZoom/SliderZoomView.ts | 4 ++--
src/component/helper/BrushController.ts | 12 ++++++------
src/component/helper/BrushTargetManager.ts | 4 ++--
src/component/helper/MapDraw.ts | 8 ++++----
src/component/toolbox/ToolboxView.ts | 4 ++--
src/component/tooltip/TooltipView.ts | 6 +++---
src/component/tooltip/seriesFormatTooltip.ts | 4 ++--
src/component/tooltip/tooltipMarkup.ts | 4 ++--
src/component/visualMap/ContinuousModel.ts | 4 ++--
src/component/visualMap/ContinuousView.ts | 8 ++++----
src/component/visualMap/PiecewiseModel.ts | 4 ++--
src/component/visualMap/VisualMapModel.ts | 4 ++--
16 files changed, 45 insertions(+), 45 deletions(-)
diff --git a/src/component/axisPointer/BaseAxisPointer.ts
b/src/component/axisPointer/BaseAxisPointer.ts
index 003fa2849..5b91847b1 100644
--- a/src/component/axisPointer/BaseAxisPointer.ts
+++ b/src/component/axisPointer/BaseAxisPointer.ts
@@ -135,7 +135,7 @@ class BaseAxisPointer implements AxisPointer {
this._axisPointerModel = axisPointerModel;
this._api = api;
- // Optimize: `render` will be called repeatly during mouse move.
+ // Optimize: `render` will be called repeatedly during mouse move.
// So it is power consuming if performing `render` each time,
// especially on mobile device.
if (!forceRender
@@ -251,7 +251,7 @@ class BaseAxisPointer implements AxisPointer {
axisPointerModel: AxisPointerModel,
api: ExtensionAPI
) {
- // Shoule be implemenented by sub-class.
+ // Should be implemenented by sub-class.
}
/**
@@ -360,7 +360,7 @@ class BaseAxisPointer implements AxisPointer {
cursor: 'move',
draggable: true,
onmousemove(e) {
- // Fot mobile devicem, prevent screen slider on the
button.
+ // For mobile device, prevent screen slider on the
button.
eventTool.stop(e.event);
},
onmousedown: bind(this._onHandleDragMove, this, 0, 0),
@@ -576,4 +576,4 @@ function updateMandatoryProps(
});
}
-export default BaseAxisPointer;
\ No newline at end of file
+export default BaseAxisPointer;
diff --git a/src/component/axisPointer/axisTrigger.ts
b/src/component/axisPointer/axisTrigger.ts
index bae5d0938..810108d86 100644
--- a/src/component/axisPointer/axisTrigger.ts
+++ b/src/component/axisPointer/axisTrigger.ts
@@ -425,8 +425,8 @@ function dispatchTooltipActually(
}
// In most case only one axis (or event one series is used). It is
- // convinient to fetch payload.seriesIndex and payload.dataIndex
- // dirtectly. So put the first seriesIndex and dataIndex of the first
+ // convenient to fetch payload.seriesIndex and payload.dataIndex
+ // directly. So put the first seriesIndex and dataIndex of the first
// axis on the payload.
const sampleItem = ((dataByCoordSys.list[0].dataByAxis[0] ||
{}).seriesDataIndices || [])[0] || {} as DataIndex;
@@ -450,7 +450,7 @@ function dispatchHighDownActually(
api: ExtensionAPI
) {
// FIXME
- // highlight status modification shoule be a stage of main process?
+ // highlight status modification should be a stage of main process?
// (Consider confilct (e.g., legend and axisPointer) and setOption)
const zr = api.getZr();
diff --git a/src/component/axisPointer/modelHelper.ts
b/src/component/axisPointer/modelHelper.ts
index c991ae0c2..81c856874 100644
--- a/src/component/axisPointer/modelHelper.ts
+++ b/src/component/axisPointer/modelHelper.ts
@@ -130,8 +130,8 @@ function collectAxesInfo(result: CollectionResult, ecModel:
GlobalModel, api: Ex
result.coordSysAxesInfo[coordSysKey] = {};
result.coordSysMap[coordSysKey] = coordSys;
- // Set tooltip (like 'cross') is a convienent way to show axisPointer
- // for user. So we enable seting tooltip on coordSys model.
+ // Set tooltip (like 'cross') is a convenient way to show axisPointer
+ // for user. So we enable setting tooltip on coordSys model.
const coordSysModel = coordSys.model as ComponentModel<ComponentOption
& {
tooltip: TooltipOption // TODO: Same with top level tooltip?
}>;
@@ -250,8 +250,8 @@ function makeAxisPointerModel(
// triggered from tooltip and trigger tooltip.
volatileOption.snap = axis.type !== 'category' && !!triggerTooltip;
- // Compatibel with previous behavior, tooltip axis do not show label by
default.
- // Only these properties can be overrided from tooltip to axisPointer.
+ // Compatible with previous behavior, tooltip axis does not show label by
default.
+ // Only these properties can be overridden from tooltip to axisPointer.
if (tooltipAxisPointerModel.get('type') === 'cross') {
volatileOption.type = 'line';
}
diff --git a/src/component/axisPointer/viewHelper.ts
b/src/component/axisPointer/viewHelper.ts
index aea2c9fe2..c31daa1d0 100644
--- a/src/component/axisPointer/viewHelper.ts
+++ b/src/component/axisPointer/viewHelper.ts
@@ -129,7 +129,7 @@ export function buildLabelElOption(
padding: paddings,
backgroundColor: bgColor as ColorString
}),
- // Lable should be over axisPointer.
+ // Label should be over axisPointer.
z2: 10
};
}
diff --git a/src/component/dataZoom/SliderZoomView.ts
b/src/component/dataZoom/SliderZoomView.ts
index 1f98f1592..a6545fdb3 100644
--- a/src/component/dataZoom/SliderZoomView.ts
+++ b/src/component/dataZoom/SliderZoomView.ts
@@ -286,7 +286,7 @@ class SliderZoomView extends DataZoomView {
? {scaleY: otherAxisInverse ? 1 : -1, scaleX: -1 }
: (orient === VERTICAL && !inverse)
? {scaleY: otherAxisInverse ? -1 : 1, scaleX: 1, rotation: Math.PI
/ 2}
- // Dont use Math.PI, considering shadow direction.
+ // Don't use Math.PI, considering shadow direction.
: {scaleY: otherAxisInverse ? -1 : 1, scaleX: -1, rotation:
Math.PI / 2}
);
@@ -1055,7 +1055,7 @@ class SliderZoomView extends DataZoomView {
}
private _findCoordRect() {
- // Find the grid coresponding to the first axis referred by dataZoom.
+ // Find the grid corresponding to the first axis referred by dataZoom.
let rect: RectLike;
const coordSysInfoList =
collectReferCoordSysModelInfo(this.dataZoomModel).infoList;
diff --git a/src/component/helper/BrushController.ts
b/src/component/helper/BrushController.ts
index 647f17c9e..38cf19749 100644
--- a/src/component/helper/BrushController.ts
+++ b/src/component/helper/BrushController.ts
@@ -32,10 +32,10 @@ import { PathStyleProps } from 'zrender/src/graphic/Path';
/**
- * BrushController not only used in "brush component",
- * but also used in "tooltip DataZoom", and other possible
- * futher brush behavior related scenarios.
- * So `BrushController` should not depends on "brush component model".
+ * BrushController is not only used in "brush component",
+ * but is also used in "tooltip DataZoom", and other possible
+ * further brush behavior related scenarios.
+ * So `BrushController` should not depend on "brush component model".
*/
@@ -410,7 +410,7 @@ class BrushController extends Eventful<{
function addOrUpdate(newIndex: number, oldIndex?: number): void {
const newBrushInternal = coverConfigList[newIndex];
// Consider setOption in event listener of brushSelect,
- // where updating cover when creating should be forbiden.
+ // where updating cover when creating should be forbidden.
if (oldIndex != null && oldCovers[oldIndex] === creatingCover) {
newCovers[newIndex] = oldCovers[oldIndex];
}
@@ -998,7 +998,7 @@ function handleDragEnd(controller: BrushController, e:
ElementEvent) {
controller._track = [];
controller._creatingCover = null;
- // trigger event shoule be at final, after procedure will be nested.
+ // trigger event should be at final, after procedure will be nested.
eventParams && trigger(controller, eventParams);
}
}
diff --git a/src/component/helper/BrushTargetManager.ts
b/src/component/helper/BrushTargetManager.ts
index a7aac46ff..9a378fd00 100644
--- a/src/component/helper/BrushTargetManager.ts
+++ b/src/component/helper/BrushTargetManager.ts
@@ -194,7 +194,7 @@ class BrushTargetManager {
// convert coordRange to global range and set panelId.
if (targetInfo && targetInfo !== true) {
area.panelId = targetInfo.panelId;
- // (1) area.range shoule always be calculate from coordRange
but does
+ // (1) area.range should always be calculate from coordRange
but does
// not keep its original value, for the sake of the dataZoom
scenario,
// where area.coordRange remains unchanged but area.range may
be changed.
// (2) Only support converting one coordRange to pixel range
in brush
@@ -244,7 +244,7 @@ class BrushTargetManager {
/**
* If return Object, a coord found.
- * If reutrn true, global found.
+ * If return true, global found.
* Otherwise nothing found.
*/
findTargetInfo(
diff --git a/src/component/helper/MapDraw.ts b/src/component/helper/MapDraw.ts
index 89827f957..2ec2c5af2 100644
--- a/src/component/helper/MapDraw.ts
+++ b/src/component/helper/MapDraw.ts
@@ -466,11 +466,11 @@ class MapDraw {
viewBuildCtx: ViewBuildContext
): void {
// It's a little complicated to support blurring the entire geoSVG in
series-map.
- // So do not suport it until some requirements come.
+ // So do not support it until some requirements come.
// At present, in series-map, only regions can be blurred.
if (focusSelf && viewBuildCtx.isGeo) {
const blurStyle = (viewBuildCtx.mapOrGeoModel as
GeoModel).getModel(['blur', 'itemStyle']).getItemStyle();
- // Only suport `opacity` here. Because not sure that other props
are suitable for
+ // Only support `opacity` here. Because not sure that other props
are suitable for
// all of the elements generated by SVG (especially for
Text/TSpan/Image/... ).
const opacity = blurStyle.opacity;
this._svgGraphicRecord.root.traverse(el => {
@@ -677,7 +677,7 @@ function applyOptionStyleForRegion(
// polyline and polygon is "open" or "close" but not fill or not).
// (2) For the common props like opacity, if some use itemStyle
// and some use `lineStyle`, it might confuse users.
- // (3) Most SVG use <path>, where can not detect wether draw a "line"
+ // (3) Most SVG use <path>, where can not detect whether to draw a "line"
// or a filled shape, so use `itemStyle` for <path>.
const normalStyleModel = regionModel.getModel('itemStyle');
@@ -685,7 +685,7 @@ function applyOptionStyleForRegion(
const blurStyleModel = regionModel.getModel(['blur', 'itemStyle']);
const selectStyleModel = regionModel.getModel(['select', 'itemStyle']);
- // NOTE: DONT use 'style' in visual when drawing map.
+ // NOTE: DON'T use 'style' in visual when drawing map.
// This component is used for drawing underlying map for both geo
component and map series.
const normalStyle = getFixedItemStyle(normalStyleModel);
const emphasisStyle = getFixedItemStyle(emphasisStyleModel);
diff --git a/src/component/toolbox/ToolboxView.ts
b/src/component/toolbox/ToolboxView.ts
index faa340418..e24be3cd9 100644
--- a/src/component/toolbox/ToolboxView.ts
+++ b/src/component/toolbox/ToolboxView.ts
@@ -117,7 +117,7 @@ class ToolboxView extends ComponentView {
}
else {
feature = features[oldName];
- // If feature does not exsit.
+ // If feature does not exist.
if (!feature) {
return;
}
@@ -169,7 +169,7 @@ class ToolboxView extends ComponentView {
const iconStyleModel = featureModel.getModel('iconStyle');
const iconStyleEmphasisModel = featureModel.getModel(['emphasis',
'iconStyle']);
- // If one feature has mutiple icon. they are orginaized as
+ // If one feature has multiple icons, they are organized as
// {
// icon: {
// foo: '',
diff --git a/src/component/tooltip/TooltipView.ts
b/src/component/tooltip/TooltipView.ts
index f99d86381..e64c2d19d 100644
--- a/src/component/tooltip/TooltipView.ts
+++ b/src/component/tooltip/TooltipView.ts
@@ -745,8 +745,8 @@ class TooltipView extends ComponentView {
tooltipModelCascade.push(cmpt as Model<TooltipableOption>);
}
// In most cases, component tooltip formatter has different params
with series tooltip formatter,
- // so that they can not share the same formatter. Since the global
tooltip formatter is used for series
- // by convension, we do not use it as the default formatter for
component.
+ // so that they cannot share the same formatter. Since the global
tooltip formatter is used for series
+ // by convention, we do not use it as the default formatter for
component.
tooltipModelCascade.push({ formatter: tooltipOpt.content });
const positionDefault = e.positionDefault;
@@ -1091,7 +1091,7 @@ function refixTooltipPosition(
if (gapH != null) {
// Add extra 2 pixels for this case:
- // At present the "values" in defaut tooltip are using CSS `float:
right`.
+ // At present the "values" in default tooltip are using CSS `float:
right`.
// When the right edge of the tooltip box is on the right side of the
// viewport, the `float` layout might push the "values" to the second
line.
if (x + width + gapH + 2 > viewWidth) {
diff --git a/src/component/tooltip/seriesFormatTooltip.ts
b/src/component/tooltip/seriesFormatTooltip.ts
index 18197bec2..6e5f7be09 100644
--- a/src/component/tooltip/seriesFormatTooltip.ts
+++ b/src/component/tooltip/seriesFormatTooltip.ts
@@ -78,8 +78,8 @@ export function defaultSeriesFormatTooltip(opt: {
return createTooltipMarkup('section', {
header: seriesName,
- // When series name not specified, do not show a header line with only
'-'.
- // This case alway happen in tooltip.trigger: 'item'.
+ // When series name is not specified, do not show a header line with
only '-'.
+ // This case always happens in tooltip.trigger: 'item'.
noHeader: multipleSeries || !seriesNameSpecified,
sortParam: sortParam,
blocks: [
diff --git a/src/component/tooltip/tooltipMarkup.ts
b/src/component/tooltip/tooltipMarkup.ts
index b893cd8c0..c8296b7e6 100644
--- a/src/component/tooltip/tooltipMarkup.ts
+++ b/src/component/tooltip/tooltipMarkup.ts
@@ -494,8 +494,8 @@ export function getPaddingFromTooltipModel(
export class TooltipMarkupStyleCreator {
readonly richTextStyles: Dictionary<Dictionary<unknown>> = {};
- // Notice that "generate a style name" usuall happens repeatly when mouse
moving and
- // displaying a tooltip. So we put the `_nextStyleNameId` as a member of
each creator
+ // Notice that "generate a style name" usually happens repeatedly when
mouse is moving and
+ // a tooltip is displayed. So we put the `_nextStyleNameId` as a member of
each creator
// rather than static shared by all creators (which will cause it increase
to fast).
private _nextStyleNameId: number = getRandomIdBase();
diff --git a/src/component/visualMap/ContinuousModel.ts
b/src/component/visualMap/ContinuousModel.ts
index ef62a7ca5..d8281bcec 100644
--- a/src/component/visualMap/ContinuousModel.ts
+++ b/src/component/visualMap/ContinuousModel.ts
@@ -46,7 +46,7 @@ export interface ContinousVisualMapOption extends
VisualMapOption {
/**
* selected range. In default case `range` is [min, max]
* and can auto change along with modification of min max,
- * util user specifid a range.
+ * until user specified a range.
*/
range?: number[]
/**
@@ -121,7 +121,7 @@ class ContinuousModel extends
VisualMapModel<ContinousVisualMapOption> {
const range = this.option.range;
if (!range || (range as RangeWithAuto).auto) {
- // `range` should always be array (so we dont use other
+ // `range` should always be array (so we don't use other
// value like 'auto') for user-friend. (consider getOption).
(dataExtent as RangeWithAuto).auto = 1;
this.option.range = dataExtent;
diff --git a/src/component/visualMap/ContinuousView.ts
b/src/component/visualMap/ContinuousView.ts
index 988694516..2b2248ef2 100644
--- a/src/component/visualMap/ContinuousView.ts
+++ b/src/component/visualMap/ContinuousView.ts
@@ -296,7 +296,7 @@ class ContinuousView extends VisualMapView {
draggable: true,
drift: onDrift,
onmousemove(e) {
- // Fot mobile devicem, prevent screen slider on the button.
+ // For mobile device, prevent screen slider on the button.
eventTool.stop(e.event);
},
ondragend: onDragEnd,
@@ -453,7 +453,7 @@ class ContinuousView extends VisualMapView {
handleEnds,
sizeExtent,
handleIndex,
- // cross is forbiden
+ // cross is forbidden
0
);
@@ -532,7 +532,7 @@ class ContinuousView extends VisualMapView {
}
) {
// Considering colorHue, which is not linear, so we have to sample
- // to calculate gradient color stops, but not only caculate head
+ // to calculate gradient color stops, but not only calculate head
// and tail.
const sampleNumber = 100; // Arbitrary value.
const colorStops: LinearGradientObject['colorStops'] = [];
@@ -930,7 +930,7 @@ function createPolygon(
cursor: cursor,
drift: onDrift,
onmousemove(e) {
- // Fot mobile devicem, prevent screen slider on the button.
+ // For mobile device, prevent screen slider on the button.
eventTool.stop(e.event);
},
ondragend: onDragEnd
diff --git a/src/component/visualMap/PiecewiseModel.ts
b/src/component/visualMap/PiecewiseModel.ts
index a0fff4b7b..7dcd63aa4 100644
--- a/src/component/visualMap/PiecewiseModel.ts
+++ b/src/component/visualMap/PiecewiseModel.ts
@@ -531,7 +531,7 @@ const resetMethods: Dictionary<ResetMethod> &
ThisType<PiecewiseModel> = {
}
else {
// `min` `max` is legacy option.
- // `lt` `gt` `lte` `gte` is recommanded.
+ // `lt` `gt` `lte` `gte` is recommended.
const interval = item.interval = [] as unknown as [number,
number];
const close: typeof item.close = item.close = [0, 0];
@@ -597,4 +597,4 @@ function normalizeReverse(thisOption:
PiecewiseVisualMapOption, pieceList: Inner
}
}
-export default PiecewiseModel;
\ No newline at end of file
+export default PiecewiseModel;
diff --git a/src/component/visualMap/VisualMapModel.ts
b/src/component/visualMap/VisualMapModel.ts
index 6f9c48684..85b3162e5 100644
--- a/src/component/visualMap/VisualMapModel.ts
+++ b/src/component/visualMap/VisualMapModel.ts
@@ -373,7 +373,7 @@ class VisualMapModel<Opts extends VisualMapOption =
VisualMapOption> extends Com
* PENDING:
* delete this method if no outer usage.
*
- * Return Concrete dimention. If return null/undefined, no dimension used.
+ * Return Concrete dimension. If null/undefined is returned, no dimension
is used.
*/
// getDataDimension(data: SeriesData) {
// const optDim = this.option.dimension;
@@ -449,7 +449,7 @@ class VisualMapModel<Opts extends VisualMapOption =
VisualMapOption> extends Com
base.inRange = {color: thisOption.color.slice().reverse()};
}
- // Compatible with previous logic, always give a defautl color,
otherwise
+ // Compatible with previous logic, always give a default color,
otherwise
// simple config with no inRange and outOfRange will not work.
// Originally we use visualMap.color as the default color, but
setOption at
// the second time the default color will be erased. So we change
to use
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
