pissang commented on code in PR #18075:
URL: https://github.com/apache/echarts/pull/18075#discussion_r1051520387
##########
src/animation/customGraphicTransition.ts:
##########
@@ -221,7 +221,7 @@ export function applyLeaveTransition(
if (leaveToProps) {
// TODO TODO use leave after leaveAnimation in series is introduced
// TODO Data index?
- const config = getElementAnimationConfig('update', el, elOption,
animatableModel, 0);
+ const config = getElementAnimationConfig('leave', el, elOption,
animatableModel, 0);
Review Comment:
It's not a typo. Because we haven't introduce `leave` animation config for
series yet. We still keep using `update` animation config here for compatitable
reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
