infacto commented on PR #17636: URL: https://github.com/apache/echarts/pull/17636#issuecomment-1419159890
Why not just extend the type with the required properties (x,y,width,height)? Exported from ECharts. Quest: Create the [custom example](https://echarts.apache.org/examples/en/editor.html?c=custom-profile) in TypeScript too. And provide the necessary types. No need to create custom types for things coming from this library. Also avoid `any` / `unknown` type or unknown additional property like `{ [key: string]: unknown }`. TS !== TS if not used correctly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
