Ovilia commented on code in PR #18390:
URL: https://github.com/apache/echarts/pull/18390#discussion_r1142840684
##########
src/component/legend/LegendModel.ts:
##########
@@ -362,6 +362,13 @@ class LegendModel<Ops extends LegendOption = LegendOption>
extends ComponentMode
name: dataItem as string
};
}
+
+ const isNil = (val: any) => val === null || val === undefined ||
val === '';
Review Comment:
Although not suggest, I think it may be valid for a series name to be `''`,
so `isNil` can be replaced by simple checking `== null`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
