roojay520 commented on code in PR #18390:
URL: https://github.com/apache/echarts/pull/18390#discussion_r1143408341
##########
src/component/legend/LegendModel.ts:
##########
@@ -362,6 +362,13 @@ class LegendModel<Ops extends LegendOption = LegendOption>
extends ComponentMode
name: dataItem as string
};
}
+
+ const isNil = (val: any) => val === null || val === undefined ||
val === '';
Review Comment:
yeh, although the series name `''` is useless for legend, it is indeed a
valid value. I changed the code and removed the handling of `''`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
