viking7982 commented on code in PR #18436:
URL: https://github.com/apache/echarts/pull/18436#discussion_r1151325882
##########
src/component/tooltip/TooltipHTMLContent.ts:
##########
@@ -291,14 +291,21 @@ class TooltipHTMLContent {
(el as any).domBelongToZr = true;
this.el = el;
const zr = this._zr = api.getZr();
- const appendToBody = this._appendToBody = opt && opt.appendToBody;
- makeStyleCoord(this._styleCoord, zr, appendToBody, api.getWidth() / 2,
api.getHeight() / 2);
-
- if (appendToBody) {
- document.body.appendChild(el);
+ let customContainer: HTMLElement | null
+ if (opt && opt.appendToBody) {
+ customContainer = this._customContainer = document.body
+ } else if (opt && opt.getAppendElement) {
Review Comment:
The variable 'container' was used by the params 'api.getDom()'.
Do u mean i should remove 'api.getDom()' from the params and then replace
'customContainer' with 'container' ?
您的意思是把TooltipHTMLContent入参中的api.getDom()移除。然后customContainer改用container这个变量名，并在使用原本container的场合用api.getDom替换是吗？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
