linghaoSu commented on code in PR #18820:
URL: https://github.com/apache/echarts/pull/18820#discussion_r1246084781
##########
src/chart/pie/PieSeries.ts:
##########
@@ -112,6 +112,7 @@ export interface PieSeriesOption extends
clockwise?: boolean
startAngle?: number
+ angleRange?: number
Review Comment:
Yes, at first I was going to use `endAngle`, but since `startAngle` has been
around for a long time, using `endAngle` would probably cause breaking change.
if `startAngle` is set to a non-default value and `endAngle` is still the
default, it's no longer a complete pie chart. So I feel that endAngle may not
be a particularly good way to go. Of course naming consistency is a great thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
