plainheart commented on code in PR #18841:
URL: https://github.com/apache/echarts/pull/18841#discussion_r1251851819
##########
src/chart/line/LineView.ts:
##########
@@ -1299,7 +1299,10 @@ class LineView extends ChartView {
});
}
if (valueAnimation) {
- labelInner(endLabel).setLabelText(value);
+ const inner = labelInner(endLabel);
Review Comment:
The existence check for `labelInner` seems unnecessary.
https://github.com/apache/echarts/blob/master/src/util/model.ts#L736C1-L741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
