linghaoSu commented on PR #18800: URL: https://github.com/apache/echarts/pull/18800#issuecomment-1774304901
> I think the logic is all right but I'd prefer the way #19180 because `setLabelLineState` is not a frequent operation and thus checking `show` in all states can be ignored. > > However, this PR gives a very solid test for it so I would also like to merge it. Can you revert the changes of `src` and pull & merge from the master and submit again? Thanks! I apologize for the delayed response. I am pleased to see that the bug has already been resolved, and I am willing to revert the code in the src directory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
