gooroodev commented on PR #19835:
URL: https://github.com/apache/echarts/pull/19835#issuecomment-2131319031
### Summary of Changes
1. **`.eslintrc-common.yaml`**:
- Added several global variables for browser environment.
- Set environment configurations for browser, node, and ES2021.
2. **`InsideZoomModel.ts`**:
- Added new options `zoomXOnMouseWheel` and `zoomYOnMouseWheel` to
control zooming on X and Y axes separately.
- Updated the default options to include these new options.
3. **`InsideZoomView.ts`**:
- Introduced private properties `lastX` and `lastY` to track the last
mouse positions.
- Added methods `handleZoom`, `handlePan`, and `handleScrollMove` to
handle zooming and panning logic.
- Enhanced the `scrollMove` handler to support new zooming functionality.
4. **`test-scroll-zoom.html`**:
- Created a new HTML test file to test the scroll zoom feature with a
sample chart.
5. **`tsconfig.json`**:
- Updated the TypeScript target from ES3 to ES6.
### Issues, Bugs, and Typos
1. **Typo in `InsideZoomModel.ts`**:
- Line 23: `configration` should be `configuration`.
2. **Typo in `test-scroll-zoom.html`**:
- Line 63: `Catergory` should be `Category`.
3. **Missing Newline at End of File**:
- The file `InsideZoomModel.ts` is missing a newline at the end of the
file.
### Proposed Improvements
**Improvement 1**:
- Correct the typo in `InsideZoomModel.ts`.
**Improvement 2**:
- Correct the typo in `test-scroll-zoom.html`.
**Improvement 3**:
- Add a newline at the end of `InsideZoomModel.ts`.
### General Review of Code Quality and Style
- **Code Quality**: The code appears to be well-structured and follows
consistent naming conventions. The addition of new features is well-integrated
into the existing codebase.
- **Code Style**: The code adheres to standard TypeScript and JavaScript
practices. Proper use of types and interfaces is maintained.
- **Documentation**: The added comments and JSDoc-like annotations are
helpful for understanding the new features and their configurations.
- **Testing**: A new test HTML file is provided to test the new scroll zoom
feature, which is a good practice to ensure functionality.
### Detailed Code Review
**Improvement 1**:
```diff
+ /**
+ * Add configuration attribute to control zoom X and Y axis.
+ */
```
**Improvement 2**:
```diff
+ xAxisData.push('Category' + i);
```
**Improvement 3**:
```diff
export default InsideZoomModel;
\ No newline at end of file
+
```
These improvements address the identified issues and enhance the overall
quality and correctness of the code.
Yours, [Gooroo.dev](https://gooroo.dev). To receive reviews automatically,
[install Github App](https://github.com/apps/gooroo-dev)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
