gooroodev commented on PR #19638:
URL: https://github.com/apache/echarts/pull/19638#issuecomment-2134551956
Thanks, @xdbobname, for the ping!
{mistakes: 1, typos: 1, security: 0, performance: 0, code_styling: 1,
others: 0}
### Summary of Changes:
1. Added support for `boundaryGap` in category axes.
2. Modified `fixExtentWithBands` to accept an optional `onBand` parameter.
3. Added a new test file `line-space-between.html` to verify the changes.
### Issues, Bugs, and Typos:
1. **Typo in Pull Request Title:**
- **Current:** enale
- **Corrected:** enable
2. **Mistake in `Axis.ts`:**
- The `onBand` parameter should be an array of two numbers, but the
default value should be `[0, 0]` instead of `[]`.
- **Correction:**
```typescript
function fixExtentWithBands(extent: [number, number], nTick: number,
onBand: number[] = [0, 0]): void {
```
### General Review of Code Quality and Style:
- The code is generally well-structured and follows good practices.
- The new feature is integrated seamlessly with existing functionality.
- The test case is well-prepared and adheres to the project's licensing and
style guidelines.
### Code Improvements:
1. **Default Value for `onBand`:**
- **File:** `src/coord/Axis.ts`
- **Line:** 273
- **Improved Code:**
```typescript
function fixExtentWithBands(extent: [number, number], nTick: number,
onBand: number[] = [0, 0]): void {
```
2. **Typo in Pull Request Title:**
- **Improved Title:**
```plaintext
feat(axis): enable boundaryGap for category axis
```
Yours, [Gooroo.dev](https://github.com/apps/gooroo-dev). React or reply to
give your feedback!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
