linghaoSu commented on code in PR #20129:
URL: https://github.com/apache/echarts/pull/20129#discussion_r1672274354
##########
src/component/legend/LegendView.ts:
##########
@@ -329,7 +329,8 @@ class LegendView extends ComponentView {
},
onclick() {
api.dispatchAction({
- type: type === 'all' ? 'legendAllSelect' :
'legendInverseSelect'
+ type: type === 'all' ? 'legendAllSelect' :
'legendInverseSelect',
+ legendId: legendModel.id
Review Comment:
看起来全选/反选在多 selector 和 单个 selector 的情况下是不一致的? 似乎不太合理？🤔
https://github.com/apache/echarts/assets/56526981/e3c2520d-ce75-42b5-8570-871eaa466da9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
