100pah commented on PR #20485:
URL: https://github.com/apache/echarts/pull/20485#issuecomment-2470734742

   
   
   Curious about why tslib 2.3.0 doesn't work.
   
   I can not reproduce it with [email protected].
   Could I have more info to reproduce it? @mrginglymus 
   
   What I've done is:
   ```shell
   npm i -D [email protected]
   npm i echarts
   touch index.html
   ```
   ```html
               <!DOCTYPE html>
               <html>
                   <head>
                       <meta charset="utf-8">
                       <meta name="viewport" content="width=device-width, 
initial-scale=1" />
                       <script 
src="./node_modules/echarts/dist/echarts.js"></script>
                   </head>
                   <body>
                       <p>good</p>
                       <div id="main" style="height: 500px; "></div>
                       <script>
                           var chart = 
echarts.init(document.getElementById('main'));
                           chart.setOption({
                               angleAxis: {
                                   type: 'category',
                                   data: ['周一', '周二', '周三', '周四', '周五', '周六', 
'周日'],
                               },
                               tooltip: {},
                               radiusAxis: {},
                               polar: { center: ['40%', '50%'] },
                               series: [{
                                   type: 'bar',
                                   data: [1, 2, '-', 3, 0, 5, 7],
                                   coordinateSystem: 'polar'
                               }]
                           });
                           chart.on('click', function (params) {
                               console.log(params);
                           });
                       </script>
                   </body>
               </html>
   ```
   ```shell
   npx vite
   ```
   
   And the chart displayed normally.
   
   
   ---
   
   @Ovilia @plainheart 
   
   Does this modification lead to breaking change? 
   Or should we do full test against different version of tslib? or check every 
breaking changes of tslib since 2.3.0 to latest?
   Or should we make this change in a patch version if it might introduce 
breaking or error?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to