mrginglymus commented on PR #20485: URL: https://github.com/apache/echarts/pull/20485#issuecomment-2470812976
Honestly I didn't spend too much time on working out the why, only the what. The error as spotted was this:  I will see if I can dig into what was wrong with vite here, as it may be worth an issue on their end as a regression. Aside from compatibility in whatever obscure set of conditions I've discovered, the more significant benefit of this change is allowing users to ship only one copy of tslib; I currently use tslib@^2.5.0 to support decorators and whilst the size of tslib is insignificant compared to the echarts stack, it still bugs me to be shipping two copies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
