Justin-ZS commented on code in PR #20710:
URL: https://github.com/apache/echarts/pull/20710#discussion_r1993110381
##########
src/component/tooltip/TooltipView.ts:
##########
@@ -365,11 +370,13 @@ class TooltipView extends ComponentView {
else if (payload.x != null && payload.y != null) {
// FIXME
// should wrap dispatchAction like `axisPointer/globalListener` ?
- api.dispatchAction({
- type: 'updateAxisPointer',
- x: payload.x,
- y: payload.y
- });
+ if (tooltipModel.option.trigger === 'axis') {
Review Comment:
I will revert this change because you think losing the "emphasis" is not a
bug.
But changing the tooltip "trigger" without updating the tooltip is certainly
a bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
