Ovilia commented on code in PR #20710:
URL: https://github.com/apache/echarts/pull/20710#discussion_r2142207629


##########
src/component/tooltip/TooltipView.ts:
##########
@@ -243,6 +243,11 @@ class TooltipView extends ComponentView {
         const api = this._api;
         const triggerOn = tooltipModel.get('triggerOn');
 
+        if (tooltipModel.option.trigger !== 'axis') {

Review Comment:
   May I ask why we should check if it's axis here? What happens if we don't 
use this if? Because I don't see other places checking this before setting 
_lastDataByCoordSys to be null.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to