sz-p commented on code in PR #18164:
URL: https://github.com/apache/echarts/pull/18164#discussion_r1998530909


##########
src/component/legend/LegendView.ts:
##########
@@ -223,8 +223,16 @@ class LegendView extends ComponentView {
                 );
 
                 itemGroup.on('click', curry(dispatchSelectAction, name, null, 
api, excludeSeriesId))

Review Comment:
   Thank you for your comments and great suggestions.
   
   I didn't consider the `triggerEvent` option, and event name need orthogonal 
composition.
   
   It was my mistake.
   
   I have modified the code, add `legend.triggerEvent`.  please help me review 
it again.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to