plainheart commented on code in PR #18164:
URL: https://github.com/apache/echarts/pull/18164#discussion_r2022058397
##########
src/component/legend/LegendView.ts:
##########
@@ -234,6 +236,11 @@ class LegendView extends ComponentView {
ecData.ssrType = 'legend';
});
}
+ itemGroup.eachChild(child => {
+ if (triggerEvent) {
Review Comment:
I suggest adding the _if_ check before the _each_ function to avoid
unnecessary invocation if `triggerEvent` is not enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
