pissang commented on code in PR #20321:
URL: https://github.com/apache/echarts/pull/20321#discussion_r2000767747
##########
src/chart/sankey/SankeyView.ts:
##########
@@ -346,6 +363,70 @@ class SankeyView extends ChartView {
}
dispose() {
+ this._controller && this._controller.dispose();
+ this._controllerHost = null;
+ }
+
+ private _updateController(
Review Comment:
Overall, the code looks good and it works properly. It would be better with
a small optimization: The code in this method is essentially the same as in
TreeSeries, so could it be shared?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
