Ovilia commented on code in PR #21173:
URL: https://github.com/apache/echarts/pull/21173#discussion_r2259233282
##########
src/component/toolbox/feature/DataView.ts:
##########
@@ -465,12 +468,12 @@ class DataView extends
ToolboxFeature<ToolboxDataViewFeatureOption> {
icon: 'M17.5,17.3H33 M17.5,17.3H33 M45.4,29.5h-28
M11.5,2v56H51V14.8L38.4,2H11.5z M38.4,2.2v12.7H51 M45.4,41.7h-28',
title: ecModel.getLocaleModel().get(['toolbox', 'dataView',
'title']),
lang: ecModel.getLocaleModel().get(['toolbox', 'dataView',
'lang']),
- backgroundColor: tokens.color.background,
- textColor: tokens.color.primary,
- textareaColor: tokens.color.background,
- textareaBorderColor: tokens.color.border,
- buttonColor: tokens.color.accent50,
- buttonTextColor: tokens.color.neutral00
+ backgroundColor: color.background,
Review Comment:
In the source code of components, light mode `tokens` should be used. To
support dark mode, you should add `dataView` options in
https://github.com/apache/echarts/blob/master/src/theme/dark.ts#L103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
