helgasoft commented on PR #20495: URL: https://github.com/apache/echarts/pull/20495#issuecomment-3324758070
@linlang171, respect for your effort. I have assembled a [list of dataZoom bugs](https://github.com/apache/echarts/issues/20392) and would love to delist some of them. Usually I do not comment on ECharts code since I don't understand it very well, want to just share some thoughts. Your PR changes one line in function _normalize_. Searching further up the ladder on where it is used I find this: normalize (helper.ts) >> ScaleCalculator (Scale.ts) >> _calculator (Interval.ts, Ordinal.ts, Time.ts) Your test _line-scale.html_ works with dataset, which I presume falls under Ordinal.ts. But there are two more places where _normalize_ is used - Interval.ts and Time.ts. Interval.ts could be related to axis and tested with `xAxis.data` ...? Not sure. Testing with `xAxis:{type:"time"}` I find that the current code works fine. How would it work with your update I don't know. So my point is - maybe more PR tests are needed ? Hard to tell without some feedback from developers... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
