TkDodo commented on issue #21279: URL: https://github.com/apache/echarts/issues/21279#issuecomment-3375650788
I’m not sure why echarts uses “fixed” dependencies: https://github.com/apache/echarts/blob/37209e20148932f4237fcef3b1192f245efe9588/package.json#L68-L71 rather than caret versions: ``` "dependencies": { “tslib": "^2.3.0", “zrender": ”^6.0.0" }, ``` that would allow consumers to deduplicate dependencies on their end. Right now, we have two versions of `tslib` packaged, because `echarts` needs exactly `2.3.0` while other packages want `"tslib": "^2.4.1"`, which brings in a higher version. with the proposed fix of doing caret versioning for dependencies, we would wind up with one version of tslib that would satisfy both constraints. Btw, `zrender` has the same problem, so it would need to be addressed there as well. I’m happy to make a PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
