Srajan-Sanjay-Saxena opened a new pull request, #21337: URL: https://github.com/apache/echarts/pull/21337
<!-- Please fill in the following information to help us review your PR more efficiently. --> ## Brief Information This pull request is in the type of: * [x] bug fixing * [ ] new feature * [ ] others ### What does this PR do? Fixes the issue where decal background color was not applied when the rendering mode was set to SVG. ### Fixed issues * #21333 ## Details ### Before: What was the problem? When rendering charts in **SVG mode**, the **decal background color** was not visible. This occurred because the existing code only handled the **Canvas** rendering case and did not include logic for SVG rendering. <!-- ADD SCREENSHOT HERE IF APPLICABLE. --> ### After: How does it behave after the fixing? The decal background color now correctly appears when charts are rendered in **SVG mode**. A separate code path was introduced to handle the **non-canvas (SVG)** case, utilizing the pattern sizes to generate appropriate SVG dimensions for decal rendering. Two new test files have been added inside: ``` test/decal_bg_svg_testing/ ``` to validate the fix in SVG rendering scenarios. <!-- ADD SCREENSHOT HERE IF APPLICABLE. --> ## Document Info One of the following should be checked. * [x] This PR doesn't relate to document changes * [ ] The document should be updated later * [ ] The document changes have been made in apache/echarts-doc#xxx ## Misc ### Security Checking * [ ] This PR uses security-sensitive Web APIs. <!-- PLEASE CHECK IT AGAINST: <https://github.com/apache/echarts/wiki/Security-Checklist-for-Code-Contributors> --> ### ZRender Changes * [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx). ### Related test cases or examples to use the new APIs Two new test cases added in `test/decal_bg_svg_testing/`. ### Merging options * [x] Please squash the commits into a single one when merging. ### Other information This fix ensures parity between Canvas and SVG rendering modes regarding decal background color rendering. https://github.com/user-attachments/assets/1de1686b-8556-4fdc-8242-7380553b7e36 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
