Ovilia commented on code in PR #21337:
URL: https://github.com/apache/echarts/pull/21337#discussion_r2502026806
##########
.gitignore:
##########
@@ -182,6 +182,7 @@ todo
*.asm
# Distribution files
+/dist/
Review Comment:
`/dist` should be uploaded when a new version release, so please revert this
change.
##########
package-lock.json:
##########
@@ -86,6 +86,7 @@
"resolved": "https://registry.npmjs.org/@babel/core/-/core-7.3.4.tgz";,
"integrity":
"sha512-jRsuseXBo9pN197KnDwhhaaBzyZr2oIcLHHTt2oDdQrej5Qp57dCCJafWx5ivU8/alEYDpssYqv1MUqcxwQlrA==",
"dev": true,
+ "peer": true,
Review Comment:
Please don't upload the changes of `package-lock.json`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
