Srajan-Sanjay-Saxena commented on code in PR #21352:
URL: https://github.com/apache/echarts/pull/21352#discussion_r2519351446
##########
src/scale/Time.ts:
##########
@@ -206,8 +206,10 @@ class TimeScale extends IntervalScale<TimeScaleSetting> {
let upperUnitIndex = primaryTimeUnits.length - 1;
let maxLevel = 0;
each(ticks, tick => {
- upperUnitIndex = Math.min(upperUnitIndex,
indexOf(primaryTimeUnits, tick.time.upperTimeUnit));
- maxLevel = Math.max(maxLevel, tick.time.level);
+ if (tick.time) {
Review Comment:
i mean yeah if you are not bothered right now about type level security and
just want fast growth of the app then you can keep it disabled ... but you know
it will always cause these kind of issues where possible nullability results
into crashing of some renderings . I guess for the next bump to a higher
version we should enable that .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
