plainheart commented on code in PR #21427:
URL: https://github.com/apache/echarts/pull/21427#discussion_r2622334314
##########
src/chart/treemap/TreemapView.ts:
##########
@@ -516,7 +516,9 @@ class TreemapView extends ChartView {
});
controllerHost.zoomLimit = seriesModel.get('scaleLimit');
- controllerHost.zoom = seriesModel.get('zoom');
+ if (controllerHost.zoom === undefined) {
Review Comment:
1. We usually use `obj == null` to check if a variable is defined.
2. `|| 1` is not necessary as there is already a fallback in [Line
588](https://github.com/apache/echarts/blob/6.0.0/src/chart/treemap/TreemapView.ts#L588).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
