This is an automated email from the ASF dual-hosted git repository. wangzx pushed a commit to branch fix/marker-dataset in repository https://gitbox.apache.org/repos/asf/echarts.git
commit 491aacdd35bfd53bbf8f8b7ecdcabffe3c7fa875 Author: plainheart <[email protected]> AuthorDate: Sun Dec 21 04:33:37 2025 +0800 fix(marker): fix marker fails to render with dataset and encode due to storeDimIndex mismatch. This regression was introduced in #20682 --- src/component/marker/MarkAreaView.ts | 6 ++++-- src/component/marker/MarkLineView.ts | 11 +++++++---- src/component/marker/MarkPointView.ts | 11 +++++++---- 3 files changed, 18 insertions(+), 10 deletions(-) diff --git a/src/component/marker/MarkAreaView.ts b/src/component/marker/MarkAreaView.ts index e3483453c..d6b8ec889 100644 --- a/src/component/marker/MarkAreaView.ts +++ b/src/component/marker/MarkAreaView.ts @@ -412,12 +412,14 @@ function createList( const data = seriesModel.getData(); const info = data.getDimensionInfo( data.mapDimension(coordDim) - ) || {}; + ) || {} as SeriesDimensionDefine; // In map series data don't have lng and lat dimension. Fallback to same with coordSys return extend(extend({}, info), { name: coordDim, // DON'T use ordinalMeta to parse and collect ordinal. - ordinalMeta: null + ordinalMeta: null, + // Keep storeDimIndex aligned with coordDimIndex for marker data + storeDimIndex: info.coordDimIndex }); }); dataDims = map(dims, (dim, idx) => ({ diff --git a/src/component/marker/MarkLineView.ts b/src/component/marker/MarkLineView.ts index 68c048b4d..10db9d8e8 100644 --- a/src/component/marker/MarkLineView.ts +++ b/src/component/marker/MarkLineView.ts @@ -443,14 +443,17 @@ function createList(coordSys: CoordinateSystem, seriesModel: SeriesModel, mlMode let coordDimsInfos: SeriesDimensionDefine[]; if (coordSys) { coordDimsInfos = map(coordSys && coordSys.dimensions, function (coordDim) { - const info = seriesModel.getData().getDimensionInfo( - seriesModel.getData().mapDimension(coordDim) - ) || {}; + const data = seriesModel.getData(); + const info = data.getDimensionInfo( + data.mapDimension(coordDim) + ) || {} as SeriesDimensionDefine; // In map series data don't have lng and lat dimension. Fallback to same with coordSys return extend(extend({}, info), { name: coordDim, // DON'T use ordinalMeta to parse and collect ordinal. - ordinalMeta: null + ordinalMeta: null, + // Keep storeDimIndex aligned with coordDimIndex for marker data + storeDimIndex: info.coordDimIndex }); }); } diff --git a/src/component/marker/MarkPointView.ts b/src/component/marker/MarkPointView.ts index bad3d19a0..bfceb7064 100644 --- a/src/component/marker/MarkPointView.ts +++ b/src/component/marker/MarkPointView.ts @@ -203,14 +203,17 @@ function createData( let coordDimsInfos: SeriesDimensionDefine[]; if (coordSys) { coordDimsInfos = map(coordSys && coordSys.dimensions, function (coordDim) { - const info = seriesModel.getData().getDimensionInfo( - seriesModel.getData().mapDimension(coordDim) - ) || {}; + const data = seriesModel.getData(); + const info = data.getDimensionInfo( + data.mapDimension(coordDim) + ) || {} as SeriesDimensionDefine; // In map series data don't have lng and lat dimension. Fallback to same with coordSys return extend(extend({}, info), { name: coordDim, // DON'T use ordinalMeta to parse and collect ordinal. - ordinalMeta: null + ordinalMeta: null, + // Keep storeDimIndex aligned with coordDimIndex for marker data + storeDimIndex: info.coordDimIndex }); }); } --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
