rosenthalj commented on issue #21374: URL: https://github.com/apache/echarts/issues/21374#issuecomment-3682614336
I few weeks ago I noticed the same problem, but was too busy with a deadline to create an Echarts GitHub issue. This morning I was finalizing the submission of a new bug for this problem when I found that @YuqiaoS had already created an issue and @Srajan-Sanjay-Saxena had submitted a PR fix. The following is the details that I was going to submit concerning this issue. Maybe the additional reproducer can be used in verifying the PR fix. The following video is of the reproducer(https://codesandbox.io/p/sandbox/hopeful-payne-hrlgz3) demonstrating the problem. https://github.com/user-attachments/assets/fe191996-d57c-4704-a66f-063ce8a33c85 Notes about the reproducer/video: 1) The reproduce is same code Echart's custom series demo (https://echarts.apache.org/examples/en/editor.html?c=custom-profile) with the following changes: --- I increased the data count from 10 to 10,000 ---I added the following toolbox: ``` toolbox: { feature: { dataZoom: {}, myButton: { icon: "path://M 10 10 H 90 V 90 H 10 L 10 10", iconStyle: { color: "red", }, onclick: () => { const option = myChart.getOption(); const iconStyle = option.toolbox[0].feature.myButton.iconStyle; iconStyle.color = iconStyle.color === "red" ? "green" : "red"; myChart.setOption(option); }, title: "button changes color when clicked, but doesn't affect the chart", }, }, }, ``` 2). The buttons when clicked do not change or modify any information or data that is used in the drawing of the chart --- The "zoom" button (using the default behavior of Echarts) only changes the mouse icon when hovering over the custom series chart --- The custom button only changes its own button color when clicked -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
