Copilot commented on code in PR #21447:
URL: https://github.com/apache/echarts/pull/21447#discussion_r2651941469
##########
src/component/dataZoom/SliderZoomView.ts:
##########
@@ -311,11 +311,13 @@ class SliderZoomView extends DataZoomView {
const size = this._size;
const barGroup = this._displayables.sliderGroup;
const brushSelect = dataZoomModel.get('brushSelect');
+ const borderRadius = dataZoomModel.get('borderRadius');
Review Comment:
The borderRadius value should have a default fallback to ensure consistency
and handle cases where it's undefined. At line 555 in the same file,
borderRadius is retrieved with `|| 0` as a fallback. This pattern should be
applied here as well to prevent potential issues with undefined values being
passed to the Rect shape's 'r' property.
```suggestion
const borderRadius = dataZoomModel.get('borderRadius') || 0;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
