Ovilia commented on code in PR #21599:
URL: https://github.com/apache/echarts/pull/21599#discussion_r3206071747
##########
src/chart/radar/RadarSeries.ts:
##########
@@ -115,13 +115,14 @@ class RadarSeriesModel extends
SeriesModel<RadarSeriesOption> {
return createTooltipMarkup('section', {
header: nameToDisplay,
sortBlocks: true,
- blocks: zrUtil.map(indicatorAxes, axis => {
+ blocks: zrUtil.map(indicatorAxes, (axis, indicatorIndex) => {
const val = data.get(data.mapDimension(axis.dim), dataIndex);
return createTooltipMarkup('nameValue', {
markerType: 'subItem',
markerColor: markerColor,
name: axis.name,
value: val,
+ dataIndex: indicatorIndex,
Review Comment:
I'm not sure whether it's a better idea to name this to be `indicatorIndex`
instead of `dataIndex`. I would like to hear what other committers think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
