This is an automated email from the ASF dual-hosted git repository. 100pah pushed a commit to branch release-dev in repository https://gitbox.apache.org/repos/asf/echarts.git
commit ee3e59ea3e19b1363b1d728c594ac7cef9acd674 Author: 100pah <[email protected]> AuthorDate: Mon May 11 23:53:07 2026 +0800 fix(lint): Fix lint command - previously not all source files are included. --- package.README.md | 13 +++++++++++++ package.json | 5 +++-- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/package.README.md b/package.README.md index 0007a007d..8505660f3 100644 --- a/package.README.md +++ b/package.README.md @@ -119,3 +119,16 @@ See `MIN_VERSION` in `echarts/build/testDts.js` for the minimal supported TS ver + @rollup/plugin-terser: + Currently @rollup/[email protected] is used, since @rollup/plugin-terser@^1.0.0 requires Node.js v20+, which may break users existing pipeline; @rollup/plugin-terser@^0.4.3 depends [email protected], which requires Node.js v20+; @rollup/[email protected] does not affect the produced min file size. It can be upgraded to v1.0.0+ in future if concrete requirements arise. + + +## ESLint + ++ cli issue: + ```shell + # The cli command should be: + npx eslint "src/**/*.ts" "ssr/client/src/**/*.ts" "extension-src/**/*.ts" + # Rather than: + npx eslint src/**/*.ts ssr/client/src/**/*.ts extension-src/**/*.ts + # The latter form could be expanded by shell in an unexpected way + # (can only match `src/xxx/yyy.ts` but fail to match `src/xxx/yyy/zzz.ts`) + ``` diff --git a/package.json b/package.json index c3dd0ad83..119bae3f5 100644 --- a/package.json +++ b/package.json @@ -66,8 +66,9 @@ "mktest:help": "node test/build/mktest.js -h", "checktype": "npx tsc --noEmit && npx tsc -p ./extension-src/bmap/tsconfig.json --noEmit", "checkheader": "node build/checkHeader.js", - "lint": "npx eslint --cache --cache-location node_modules/.cache/eslint src/**/*.ts ssr/client/src/**/*.ts extension-src/**/*.ts", - "lint:nocache": "npx eslint src/**/*.ts ssr/client/src/**/*.ts extension-src/**/*.ts", + "lint": "npx eslint --cache --cache-location node_modules/.cache/eslint \"src/**/*.ts\" \"ssr/client/src/**/*.ts\" \"extension-src/**/*.ts\"", + "lint:nocache": "npx eslint \"src/**/*.ts\" \"ssr/client/src/**/*.ts\" \"extension-src/**/*.ts\"", + "lint:nocache:list": "npm run lint:nocache -- --debug 2>&1 | grep \"filePath\"", "lint:fix": "npx eslint --fix src/**/*.ts extension-src/**/*.ts", "lint:dist": "echo 'It might take a while. Please wait ...' && npx jshint --config .jshintrc-dist dist/echarts.js" }, --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
