rahul37wallst-sudo opened a new pull request, #21664:
URL: https://github.com/apache/echarts/pull/21664
<!-- Please fill in the following information to help us review your PR more
efficiently. -->
## Brief Information
This pull request is in the type of:
- [x] bug fixing
- [ ] new feature
- [ ] others
### What does this PR do?
Respect disabled emphasis for line-series tooltip hover symbols.
### Fixed issues
- #21634: Fix dirty-rect repaint corruption for dense canvas line series
with tooltip axis-pointer hover.
## Details
### Before: What was the problem?
For dense canvas line series with `showSymbol: false`, `useDirtyRect: true`,
tooltip axis-pointer hover, and `emphasis: { disabled: true }`,
`LineView.highlight()` could still create a temporary hover symbol.
That temporary symbol was later removed during downplay. The add/remove
lifecycle could leave stale or corrupted line pixels when dirty-rect
repainting
was enabled.
This reproduced with the issue's ECharts 6.1.0 canvas scenario:
- dense line series
- `showSymbol: false`
- `progressive`
- piecewise `visualMap`
- tooltip `trigger: 'axis'`
- tooltip axis pointer
- `useDirtyRect: true`
- `emphasis: { disabled: true }`
### After: How does it behave after the fixing?
When line-series emphasis is disabled, `LineView.highlight()` no longer
creates
or highlights a temporary hover symbol, and `downplay()` avoids symbol/whole
series downplay work for disabled emphasis.
The existing polyline state transition is kept so dirty-rect invalidation
still
clears tooltip axis-pointer updates correctly.
Verified with a pixel-diff harness comparing a dirty-rect chart against a
full-repaint control:
- native mouse hover: 0 mismatches
- `showTip` action: 0 mismatches
- settled after `hideTip`: 0 mismatches
Also passed:
```sh
npm run lint
npm run checktype
```
Document Info
One of the following should be checked.
- [x] This PR doesn't relate to document changes
- [ ] The document should be updated later
- [ ] The document changes have been made in apache/echarts-doc#xxx
## Misc
### Security Checking
- [ ] This PR uses security-sensitive Web APIs.
<!-- PLEASE CHECK IT AGAINST:
<https://github.com/apache/echarts/wiki/Security-Checklist-for-Code-Contributors>
-->
### ZRender Changes
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
N.A.
### Merging options
- [x] Please squash the commits into a single one when merging.
### Other information
This fix was investigated together with ecomfe/zrender#1159. The ZRender
dirty-rect changes improved related behavior but did not fully resolve this
ECharts-side temp-symbol path. The final fix here is independent of ZRender
changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
